Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: actually add dispose Symbols to Node globals #14909

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 20, 2024

Summary

It seems #14888 didn't actually work - the symbols weren't available inside tests

Test plan

e2e test added

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit 65c2960
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/65d465e3abd43d000874db08
😎 Deploy Preview https://deploy-preview-14909--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB SimenB enabled auto-merge (squash) February 20, 2024 08:44
@SimenB SimenB disabled auto-merge February 20, 2024 08:56
@SimenB SimenB merged commit 9914dc4 into jestjs:main Feb 20, 2024
57 of 58 checks passed
@SimenB SimenB deleted the actually-add-dispose-symbols branch February 20, 2024 09:09
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant